Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix moist baro wave #1919

Closed
wants to merge 1 commit into from
Closed

Fix moist baro wave #1919

wants to merge 1 commit into from

Conversation

charleskawczynski
Copy link
Member

This PR fixes the moist baro wave

@charleskawczynski charleskawczynski force-pushed the ck/moist_bw_gpu branch 3 times, most recently from 638cff5 to d70e873 Compare July 26, 2023 19:57
@charleskawczynski charleskawczynski marked this pull request as ready for review July 26, 2023 20:36
@charleskawczynski
Copy link
Member Author

bors r+

@charleskawczynski
Copy link
Member Author

@szy21, can you try edmf on the gpu once this merges?

@szy21
Copy link
Member

szy21 commented Jul 26, 2023

Sounds good. Do I just follow the example in buildkite?

@charleskawczynski
Copy link
Member Author

Sounds good. Do I just follow the example in buildkite?

Yeah, you should be able to just use the edmf example and add GPU resources (--device = "auto" by default, so it can have the exact same CL model flags)

bors bot added a commit that referenced this pull request Jul 26, 2023
@bors @charleskawczynski
Merge #1919
0b4cf6f 
1919: Fix moist baro wave r=charleskawczynski a=charleskawczynski

This PR fixes the moist baro wave

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 26, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@szy21
Copy link
Member

szy21 commented Jul 27, 2023

I think it's merged, but for some reason this PR is not closed.

@charleskawczynski
Copy link
Member Author

Yeah, that's a bit odd. closing.

@charleskawczynski charleskawczynski mentioned this pull request Jul 27, 2023
Closed
@charleskawczynski charleskawczynski deleted the ck/moist_bw_gpu branch October 6, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
GPU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charleskawczynski @szy21