Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix precomputed quantities for Rosenbrock timestepper #3204

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Fix precomputed quantities for Rosenbrock timestepper #3204

merged 1 commit into from
Jul 19, 2024

Conversation

dennisYatunin
Copy link
Member

Purpose

This PR tries out CliMA/ClimaTimeSteppers.jl#305 in ClimaAtmos.jl

  • I have read and checked the items on the review checklist.

@dennisYatunin dennisYatunin requested a review from szy21 July 17, 2024 22:40
szy21
szy21 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the Manifest in docs/ too

Project.toml Show resolved Hide resolved
@dennisYatunin dennisYatunin force-pushed the dy/rosenbrock_precomputed_quantities branch from 9580423 to 301b772 Compare July 18, 2024 23:01
@dennisYatunin dennisYatunin force-pushed the dy/rosenbrock_precomputed_quantities branch from 301b772 to 28e1013 Compare July 19, 2024 00:16
@dennisYatunin dennisYatunin added this pull request to the merge queue Jul 19, 2024
Merged via the queue into main with commit 6cd42b1 Jul 19, 2024
13 of 14 checks passed
@dennisYatunin dennisYatunin deleted the dy/rosenbrock_precomputed_quantities branch July 19, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szy21 szy21 szy21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dennisYatunin @szy21