Use accessor for ClimaAnalysis units #3272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
force-pushed
the
gb/climaanalysis_units
branch
from
e7ad7c0
to
d0ad428
Compare
szy21
approved these changes
Aug 29, 2024
Sbozzolo
force-pushed
the
gb/climaanalysis_units
branch
from
d0ad428
to
b0a15e8
Compare
I thought we were already using 0.5.7 (it was released 2 weeks ago), but clearly no. Updating it now. |
CliMA/ClimaAnalysis.jl#70 is _slightly_ breaking if units are accessed directly
Sbozzolo
force-pushed
the
gb/climaanalysis_units
branch
from
b0a15e8
to
e769a06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CliMA/ClimaAnalysis.jl#70 is very slightly breaking if units are accessed directly (the return value might no longer be a String, but can still be printed as a string). To be safe, I changed to use the getter function.