Skip to content

Commit

Permalink
Merge #1396
Browse files Browse the repository at this point in the history
1396: Use cached variables more r=charleskawczynski a=charleskawczynski

This PR uses `gᵢⱼ` and `gⁱʲ` in more `project/transform` methods:

```
project(ax::CovariantAxis,v::ContravariantTensor,local_geometry::LocalGeometry)
transform(ax::CovariantAxis,v::ContravariantTensor,local_geometry::LocalGeometry)
transform(ax::ContravariantAxis, v::CovariantTensor, local_geometry::LocalGeometry)
```


Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
  • Loading branch information
bors[bot] and charleskawczynski authored Jul 27, 2023
2 parents 12d6876 + 1135087 commit c3e488e
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions src/Geometry/conversions.jl
Original file line number Diff line number Diff line change
Expand Up @@ -362,9 +362,7 @@ for op in (:transform, :project)
local_geometry::LocalGeometry,
) = $op(
ax,
local_geometry.∂x∂ξ' *
local_geometry.∂x∂ξ *
$op(dual(axes(local_geometry.∂x∂ξ, 2)), v),
local_geometry.gᵢⱼ * $op(dual(axes(local_geometry.∂x∂ξ, 2)), v),
)

$op(ato::CovariantAxis, v::CovariantTensor, ::LocalGeometry) =
Expand All @@ -383,9 +381,7 @@ transform(
local_geometry::LocalGeometry,
) = project(
ax,
local_geometry.∂ξ∂x *
local_geometry.∂ξ∂x' *
project(dual(axes(local_geometry.∂ξ∂x, 1)), v),
local_geometry.gⁱʲ * project(dual(axes(local_geometry.∂ξ∂x, 1)), v),
)

@generated function project(
Expand Down

0 comments on commit c3e488e

Please sign in to comment.