Refactor SchurComplementW for ClimaTimesteppers #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 14, 2023
1364: Refactor SchurComplementW for ClimaTimesteppers r=charleskawczynski a=charleskawczynski This PR is a peel off from #1358. This PR adds `temp1` and `temp2` to `SchurComplementW`, and defines ```julia linsolve!(::Type{Val{:init}}, f, u0; kwargs...) = _linsolve! _linsolve!(x, A, b, update_matrix = false; kwargs...) = LinearAlgebra.ldiv!(x, A, b) # Function required by Krylov.jl (x and b can be AbstractVectors) # See JuliaSmoothOptimizers/Krylov.jl#605 for a # related issue that requires the same workaround. function LinearAlgebra.ldiv!(x, A::SchurComplementW, b) A.temp1 .= b LinearAlgebra.ldiv!(A.temp2, A, A.temp1) x .= A.temp2 end ``` and the original `_linsolve` contents are in ```julia function LinearAlgebra.ldiv!( x::Fields.FieldVector, A::SchurComplementW, b::Fields.FieldVector, ) ``` (the pattern used in ClimaAtmos). It also renames `_linsolve!` to `test_linsolve!` to avoid a name collision in the test suite. It's a much smaller PR than it appears, due to indenting. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
|
Build failed: |
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a peel off from #1358.
This PR adds
temp1andtemp2toSchurComplementW, and definesand the original
_linsolvecontents are in(the pattern used in ClimaAtmos). It also renames
_linsolve!totest_linsolve!to avoid a name collision in the test suite.It's a much smaller PR than it appears, due to indenting.