Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widen OrdinaryDiffEq and SciMLBase compat range #1358

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Widen OrdinaryDiffEq and SciMLBase compat range #1358

merged 2 commits into from
Aug 1, 2023

Conversation

charleskawczynski
Copy link
Member

@charleskawczynski charleskawczynski commented Jul 6, 2023 •
edited
Loading

This is kind of a peel off from #1235. This PR widens the compat range for OrdinaryDiffEq and SciMLBase

@charleskawczynski
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 6, 2023
@bors
Try #1358:
85e88e5
@bors
Copy link
Contributor

bors bot commented Jul 6, 2023

try

Build failed:

@charleskawczynski
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 6, 2023
@bors
Try #1358:
5bfc561
@bors
Copy link
Contributor

bors bot commented Jul 6, 2023

try

Build failed:

@charleskawczynski
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 10, 2023
@bors
Try #1358:
658e584
@bors
Copy link
Contributor

bors bot commented Jul 10, 2023

try

Build failed:

@charleskawczynski charleskawczynski marked this pull request as ready for review July 11, 2023 17:14
@charleskawczynski
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 11, 2023
@bors
Try #1358:
8b2b153
@bors
Copy link
Contributor

bors bot commented Jul 11, 2023

try

Build failed:

@charleskawczynski charleskawczynski mentioned this pull request Jul 11, 2023
Closed
@charleskawczynski charleskawczynski changed the title Try upgrading packages Upgrade stale OrdinaryDiffEq packages Jul 11, 2023
@charleskawczynski
Copy link
Member Author

This has gotten kind of big, and I have no idea why the IGW example is breaking, which worked on the previous commit.. I'll break this down.

@charleskawczynski charleskawczynski marked this pull request as draft July 11, 2023 18:35
@charleskawczynski charleskawczynski mentioned this pull request Jul 11, 2023
Merged
@simonbyrne
Copy link
Member

We can also just ditch OrdinaryDiffEq support for now if that is easier?

@charleskawczynski charleskawczynski marked this pull request as ready for review July 28, 2023 22:36
@charleskawczynski
Copy link
Member Author

I'm happy to merge this if we can merge #1400 first, cc @simonbyrne

@charleskawczynski
Copy link
Member Author

The IGW problem needed a smaller dt. I'm going to bisect once or twice to preserve resources.

@charleskawczynski
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 28, 2023
@bors
Try #1358:
e6cb870
@bors
Copy link
Contributor

bors bot commented Jul 28, 2023

try

Build failed:

@charleskawczynski
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 30, 2023
@bors
Try #1358:
2f57257
@bors
Copy link
Contributor

bors bot commented Jul 30, 2023

try

Build failed:

@charleskawczynski
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 31, 2023
@bors
Try #1358:
940ce1d
@bors
Copy link
Contributor

bors bot commented Jul 31, 2023

try

Build failed:

@charleskawczynski
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 31, 2023
@bors
Try #1358:
2ca06d2
@charleskawczynski charleskawczynski mentioned this pull request Jul 31, 2023
Merged
@bors
Copy link
Contributor

bors bot commented Jul 31, 2023

try

Build failed:

bors bot added a commit that referenced this pull request Aug 1, 2023
@bors @charleskawczynski
Merge #1401
f84433c 
1401: Use ClimaTimeSteppers r=charleskawczynski a=charleskawczynski

This is a peel off from #1358.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@charleskawczynski
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Aug 1, 2023
@bors
Try #1358:
5dcda51
@bors
Copy link
Contributor

bors bot commented Aug 1, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@charleskawczynski charleskawczynski changed the title Upgrade stale OrdinaryDiffEq packages Widen OrdinaryDiffEq and SciMLBase compat range Aug 1, 2023
@charleskawczynski
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 1, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 9a62d83 into main Aug 1, 2023
6 checks passed
@bors bors bot deleted the ck/deps branch August 1, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charleskawczynski @simonbyrne