Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagonalize isapprox #1307

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Diagonalize isapprox #1307

merged 1 commit into from
Jul 6, 2023

Conversation

charleskawczynski
Copy link
Member

@charleskawczynski charleskawczynski commented Jun 11, 2023 •
edited
Loading

This PR diagonalize isapprox

@charleskawczynski
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jun 11, 2023
@bors
Try #1307:
45329db
@bors
Copy link
Contributor

bors bot commented Jun 11, 2023

try

Build failed:

@charleskawczynski
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jun 12, 2023
@bors
Try #1307:
139b6aa
@bors
Copy link
Contributor

bors bot commented Jun 12, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@charleskawczynski charleskawczynski marked this pull request as ready for review June 14, 2023 00:55
@charleskawczynski
Copy link
Member Author

Is this easier for the compiler?

@charleskawczynski
Copy link
Member Author

At the very least, type diagonalizarion will yield better errors in isapprox.

@charleskawczynski
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Jul 6, 2023
@bors @charleskawczynski
Merge #1307
407ce1c 
1307: Use type hinting to skip repeated inference r=charleskawczynski a=charleskawczynski

This PR attempts to skip repeated inference by type hinting.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 6, 2023

Build failed:

@charleskawczynski charleskawczynski changed the title Use type hinting to skip repeated inference Diagonalize isapprox Jul 6, 2023
@charleskawczynski
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 6, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 8faf2c6 into main Jul 6, 2023
5 checks passed
@bors bors bot deleted the ck/implicit_tests_inf branch July 6, 2023 16:30
@simonbyrne
Copy link
Member

wait, did we resolve the issue with views?

@charleskawczynski
Copy link
Member Author

wait, did we resolve the issue with views?

Yeah, I reverted adding the type hint on delta, which is where we had the errors with the views

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbyrne simonbyrne Awaiting requested review from simonbyrne

Assignees
No one assigned
Labels
Inference Performance tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charleskawczynski @simonbyrne