Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing bug in 3d rising bubble driver. #1318

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Fix parsing bug in 3d rising bubble driver. #1318

merged 1 commit into from
Jun 13, 2023

Conversation

sriharshakandala
Copy link
Member

@sriharshakandala sriharshakandala commented Jun 12, 2023 •
edited
Loading

  • Code follows the style guidelines OR N/A.
  • Unit tests are included OR N/A.
  • Code is exercised in an integration test OR N/A.
  • Documentation has been added/updated OR N/A.

@sriharshakandala
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jun 12, 2023
@bors
Try #1318:
c98289d
@bors
Copy link
Contributor

bors bot commented Jun 12, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@sriharshakandala sriharshakandala force-pushed the sk/parsing_bug_fix_3dbubbledriver branch from d1af6c5 to f157ef8 Compare June 12, 2023 23:31
@sriharshakandala sriharshakandala changed the title Fix parsing bug for custom resolution option in 3d rising bubble driver. Fix parsing bug in 3d rising bubble driver. Jun 12, 2023
@sriharshakandala
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jun 12, 2023
@bors
Try #1318:
edad30f
@bors
Copy link
Contributor

bors bot commented Jun 12, 2023

try

Build failed:

@sriharshakandala
Copy link
Member Author

bors try-

@sriharshakandala
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jun 12, 2023
@bors
Try #1318:
674a16a
@bors
Copy link
Contributor

bors bot commented Jun 13, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@sriharshakandala sriharshakandala linked an issue Jun 13, 2023 that may be closed by this pull request
Run the GPU bubble at reasonable resolution #1284
Closed
4 tasks
@sriharshakandala
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 13, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 8e77c96 into main Jun 13, 2023
@bors bors bot deleted the sk/parsing_bug_fix_3dbubbledriver branch June 13, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbyrne simonbyrne simonbyrne approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run the GPU bubble at reasonable resolution
2 participants
@sriharshakandala @simonbyrne