-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run all unit tests in buildkite #1321
Conversation
bors try |
tryBuild failed: |
0de94ef
to
810c229
Compare
bors try |
810c229
to
8fe83db
Compare
bors try |
tryAlready running a review |
tryBuild failed: |
bors try |
tryBuild failed: |
8fe83db
to
e92968f
Compare
bors try |
tryBuild failed: |
e92968f
to
1e10b3d
Compare
bors try |
tryBuild failed: |
1e10b3d
to
8b6367f
Compare
bors try |
tryBuild failed: |
8b6367f
to
f3564f5
Compare
can we split out the tests which are triggered from |
Is it practical to separate out tests that need to be run with |
I was hoping to handle that more systematically in a follow-up PR. Right now in main, we don't have a clear partition what is included in My thought was that we could parse the buildkite yaml file and include all unit tests (based on |
Ah, good catch, I wasn't consistent with that. I think all unit tests should have |
It is possible that #1322 may fix the |
What's the issue with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me
e5a4fb2
to
3537377
Compare
3537377
to
fdb0429
Compare
bors r+ |
1321: Run all unit tests in buildkite r=charleskawczynski a=charleskawczynski This PR: - moves all of the unit tests into buildkite. - Deletes the `test/gpu/device.jl` file, since it's from a deprecated module - Moves `test/gpu/data.jl → test/DataLayouts/cuda.jl` - Attempts to improve the grouping and labeling of the tests in the buildkite pipeline I've also incorporated #1319. This is a pretty big step towards #837. Making bors not depend on GHA would effectively close the issue. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors r- |
Canceled. |
bors r+ |
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
1381: Add CUDA field tests r=charleskawczynski a=charleskawczynski This PR adds CUDA field tests (and applies some fixes + adds some notes). We should probably do this before #1380 so that we only need to slightly modify the test suite. This was never actually tested. Here is a snapshot before #1321, which shows that `field.jl` was only on buildkite, and didn't have a gpu job: https://github.com/CliMA/ClimaCore.jl/tree/f38795b0769a6134afbba96ac1e66318c976ccd0 Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
1381: Add CUDA field tests r=charleskawczynski a=charleskawczynski This PR adds CUDA field tests (and applies some fixes + adds some notes). We should probably do this before #1380 so that we only need to slightly modify the test suite. This was never actually tested. Here is a snapshot before #1321, which shows that `field.jl` was only on buildkite, and didn't have a gpu job: https://github.com/CliMA/ClimaCore.jl/tree/f38795b0769a6134afbba96ac1e66318c976ccd0 Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
1381: Add CUDA field tests r=charleskawczynski a=charleskawczynski This PR adds CUDA field tests (and applies some fixes + adds some notes). We should probably do this before #1380 so that we only need to slightly modify the test suite. This was never actually tested. Here is a snapshot (https://github.com/CliMA/ClimaCore.jl/tree/f38795b0769a6134afbba96ac1e66318c976ccd0) before #1321, which shows that `field.jl` was only on buildkite, and didn't have a gpu job Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
1381: Add CUDA field tests r=charleskawczynski a=charleskawczynski This PR adds CUDA field tests (and applies some fixes + adds some notes). We should probably do this before #1380 so that we only need to slightly modify the test suite. This was never actually tested. Here is a snapshot (https://github.com/CliMA/ClimaCore.jl/tree/f38795b0769a6134afbba96ac1e66318c976ccd0) before #1321, which shows that `field.jl` was only on buildkite, and didn't have a gpu job Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
This PR:
test/gpu/device.jl
file, since it's from a deprecated moduletest/gpu/data.jl → test/DataLayouts/cuda.jl
I've also incorporated #1319.
This is a pretty big step towards #837. Making bors not depend on GHA would effectively close the issue.