Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compats and github workflows #1852

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Update compats and github workflows #1852

merged 5 commits into from
Jul 2, 2024

Conversation

Sbozzolo
Copy link
Member

Closes #1849, #1734, #1717, #1705, #1706

@Sbozzolo Sbozzolo force-pushed the gb/update branch 3 times, most recently from 1ac07e8 to db92f6e Compare June 28, 2024 22:18
@Sbozzolo Sbozzolo marked this pull request as ready for review June 28, 2024 22:18
Copy link
Member

@charleskawczynski charleskawczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support the compat/GHA related changes, but I'm a bit hesitant on the @static pkgversion(ClimaComms) >= v"0.6" && additions. I left a more detailed message about that. I'd prefer we remove them, but please have a look at the more detailed message.

@Sbozzolo
Copy link
Member Author

I support the compat/GHA related changes, but I'm a bit hesitant on the @static pkgversion(ClimaComms) >= v"0.6" && additions. I left a more detailed message about that. I'd prefer we remove them, but please have a look at the more detailed message.

Yes, I think we are over the update to 0.6, so I don't have problems with just bumping the compat.

@Sbozzolo
Copy link
Member Author

Sbozzolo commented Jul 1, 2024

https://buildkite.com/clima/climacore-ci/builds/3953#01906f2f-ff58-4d80-80d1-7c4b5e2d4403

Number of JET failures: Test Failed at /central/scratch/esm/slurm-buildkite/climacore-ci/3953/climacore-ci/test/Spaces/opt_spaces.jl:19
  Expression: n_found ≤ n_allowed
   Evaluated: 295 ≤ 287

For test_n_failures(287, TU.SpectralElementSpace2D, context)

I am thinking that the only possible explanation is that now we use a newer version of BlockArrays?

@charleskawczynski
Copy link
Member

https://buildkite.com/clima/climacore-ci/builds/3953#01906f2f-ff58-4d80-80d1-7c4b5e2d4403

Number of JET failures: Test Failed at /central/scratch/esm/slurm-buildkite/climacore-ci/3953/climacore-ci/test/Spaces/opt_spaces.jl:19
  Expression: n_found ≤ n_allowed
   Evaluated: 295 ≤ 287

For test_n_failures(287, TU.SpectralElementSpace2D, context)

I am thinking that the only possible explanation is that now we use a newer version of BlockArrays?

Yeah, let's just bump the limit and upgrade our dependencies. The type instability from get!(Cache.OBJECT_CACHE) complicates how many inference failures are reported, so it's possible that upgrading is not even an issue.

@Sbozzolo Sbozzolo merged commit ea976a6 into main Jul 2, 2024
17 of 19 checks passed
@Sbozzolo Sbozzolo deleted the gb/update branch July 2, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants