Reduce dependence on OrdinaryDiffEq #1977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/reduce_deps_iter2
branch
2 times, most recently
from
668475b
to
609d297
Compare
charleskawczynski
force-pushed
the
ck/reduce_deps_iter2
branch
from
609d297
to
116f989
Compare
Sbozzolo
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces our dependence on OrdinaryDiffEq. This is done by depending on OrdinaryDiffEqSSPRK, which is significantly more lightweight. This PR doesn't fully remove the dependence on OrdinaryDiffEq, since there are still some things that we override. Where possible, I switched to SciMLBase, which is more lightweight still.
Hoping this works 🤞🏻