Commits on Sep 19, 2024

1. Fix InputOutput when enable_bubble is true …

   It turns out that we were not saving and restoring a piece of
   information that is required to fully reconstruct a `2DSpectralSpace`:
   the bubble correction.
   
   When enabled, the bubble correction recomputes the Jacobian to improve
   their accuracy. `InputOutput` was not saving this piece of information
   into the HDF5 file, so spaces read from file always assumed that it was
   false. This led to discrepancies in the space, and these discrepancies
   led to problems in the evolution.
   
   Interestingly, for the low-resolution cases we consider in the Atmos CI,
   `enable_bubble` has very small effects on the value of the Jacobian,
   with a relative difference compared to the case without bubble smaller
   than the floating point precision for Float32. In spite of this, it
   affected the evolution in more noticeable way, in particular in vectors
   and with hyperdiffusion.
   
   Now, `bubble` is saved as attribute so that it can be read back.
   
   This commit also bumps the version of ClimaCore to 0.14.6

   

   Sbozzolo committed Sep 19, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 5a6d369
   • Browse repository at this point

   Copy the full SHA

   5a6d369 View commit details

   Browse the repository at this point in the history