Make Nh a dynamic parameter #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/dynamic_Nh
branch
5 times, most recently
from
d13a510
to
1c42093
Compare
charleskawczynski
force-pushed
the
ck/dynamic_Nh
branch
from
1c42093
to
b78eedf
Compare
Sbozzolo
approved these changes
Sep 27, 2024
|
I'm going to test this out in Atmos, first. |
|
Based on https://buildkite.com/clima/climacoupler-amip/builds/86#01924641-c4af-4d7f-aae0-b705fd71593b and https://buildkite.com/clima/climacoupler-amip/builds/81#01924583-5e69-4cc3-b445-76bc95b26646, there's about a ~2% slowdown. That said, I know that compilation time in a handful of Atmos CI jobs are significantly improved with this PR. So let's merge for now, and then we can revert it down the road when some of the julia latency issues are alleviated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #1894 as we are running into extremely large compile times.
Please note that this may cause runtime slowdowns, because
Nhwill be (again) no longer statically known.Perhaps we can revert this PR once JuliaLang/julia#55807 is resolved.