Fix CommonSpaces and MPI #2176
Open
Fix CommonSpaces and MPI #2176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
force-pushed
the
gb/common_mpi
branch
4 times, most recently
from
19f1a7f to
a7ec52d
Compare
4 tasks
The `CommonGrids` module passes down the context to all the grid it creates. This is a problem for IntervalTopology, because it can only be created with Singletons. This commit fixes this issue and adds test checking that we can create CommonSpaces with MPI and CUDA
`CommonSpaces.CellCenter` is more ideomatic and is a better example on how to use the CommonSpaces feature
Sbozzolo
force-pushed
the
gb/common_mpi
branch
from
a7ec52d to
10dcf4d
Compare
| @@ -34,7 +37,7 @@ using Test | |||
| h_elem = 10, | |||
| n_quad_points = 4, | |||
| horizontal_layout_type = DataLayouts.IJHF, | |||
| staggering = Grids.CellCenter(), | |||
| staggering = CommonSpaces.CellCenter(), | |||
There was a problem hiding this comment.
Can you please revert this? CellCenter/CellFace is not an object defined in CommonSpaces.
There was a problem hiding this comment.
I thought we decided to re-export it and use it directly from CommonSpaces when working with CommonSpaces.
This change ensures that those looking at this code have a good pattern to copy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CommonGridsmodule passes down the context to all the grid it creates. This is a problem for IntervalTopology, because it can only be created with Singletons.This commit fixes this issue and adds test checking that we can create CommonSpaces with MPI and CUDA
Closes #2175