Skip to content

Commit

Permalink
partial review comments [skip ci]
Browse files Browse the repository at this point in the history
  • Loading branch information
kmdeck committed Sep 12, 2024
1 parent 9158f92 commit 7d095a8
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .buildkite/longruns_gpu/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ steps:
artifact_paths: "land_longrun_gpu/*png"
agents:
slurm_gpus: 1
slurm_time: 08:00:00
slurm_time: 03:00:00
env:
CLIMACOMMS_DEVICE: "CUDA"

Expand Down
10 changes: 7 additions & 3 deletions src/standalone/Vegetation/PlantHydraulics.jl
Original file line number Diff line number Diff line change
Expand Up @@ -342,11 +342,15 @@ Computes the water flux given the absolute potential (pressure/(ρg))
and the conductivity along
the flow path between these two points.
We currently assuming an geometric
mean for mean K_sat between the two points. Previously,
We currently assuming a harmonic
mean for mean K_sat between the two points (see CLM Technical Documentation). Previously,
we used the arithmetic mean (Bonan, 2019; Zhu, 2008),
but then when the soil K was very low, root extraction would
continue. This should be modified for compartments of differing sizes.
continue.
Following CLM, this should be modified for compartments of
differing sizes because the water will travel different path lengths
in each compartment. Hence we should weight each K as K -> K/path length.
"""
function flux(z1::FT, z2::FT, ψ1::FT, ψ2::FT, K1::FT, K2::FT) where {FT}
K_eff = K1 * K2 / max(K1 + K2, eps(FT))
Expand Down

0 comments on commit 7d095a8

Please sign in to comment.