Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to plant hydraulics model #159

Open
6 tasks
kmdeck opened this issue Feb 24, 2023 · 4 comments
Open
6 tasks

Improvements to plant hydraulics model #159

kmdeck opened this issue Feb 24, 2023 · 4 comments
Assignees
@gagnelandmanna @kmdeck
Labels
enhancement New feature or request

Comments

@kmdeck
Copy link
Collaborator

kmdeck commented Feb 24, 2023 •
edited
Loading

Tasks
Beta Give feedback

Other notes from before:

  • pass layer widths instead of compartment surfaces
  • if there are no stem compartments, we still need to specify stem properties.
  • rename midpoiints ->centers and surfaces -> faces to be in line with finite difference conventions
  • create a default parameter set
@kmdeck
Copy link
Collaborator Author

kmdeck commented Feb 24, 2023

tagging @gagnelandmanna for visibility, but either one of us can work on these or add to this list

@gagnelandmanna
Copy link
Contributor

hi Katherine ok - depending on how i can juggle advancing the other pr and my other work, I will try to get to this but it may take a little while.

@kmdeck
Copy link
Collaborator Author

kmdeck commented Feb 24, 2023

oh yeah! not assigning to you, but it's all stuff I'd want your opinion on before implementing.

@gagnelandmanna
Copy link
Contributor

okidoki :) always happy to exchange yes

@kmdeck kmdeck added the enhancement New feature or request label Mar 8, 2023
This was referenced Apr 6, 2023
Closed
Closed
Merged
bors bot added a commit that referenced this issue May 31, 2023
@bors @gagnelandmanna
Merge #185
bd246fa 
185: Including new vulnerability and p to theta curves  r=kmdeck a=gagnelandmanna

## Purpose 
The purpose of this PR is to change the vulnerability curve (K(P)) and water retention curve (to convert between P and theta) used in plant hydraulics, as well as to add in the infrastructure for adding new models for this/allowing for modularity.

#159 -- this will link to issue 159

Review checklist

I have:
- followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/
- followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/
- followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy
- checked that this PR does not duplicate an open PR.

In the Content, I have included 
- relevant unit tests, and integration tests, 
- appropriate docstrings on all functions, structs, and modules, and included relevant documentation.

----
- [x] I have read and checked the items on the review checklist.

Co-authored-by: Anna GL <gagnelandmanna@gmail.com>
bors bot added a commit that referenced this issue May 31, 2023
@bors @gagnelandmanna
Merge #185
ccb194a 
185: Including new vulnerability and p to theta curves  r=kmdeck a=gagnelandmanna

## Purpose 
The purpose of this PR is to change the vulnerability curve (K(P)) and water retention curve (to convert between P and theta) used in plant hydraulics, as well as to add in the infrastructure for adding new models for this/allowing for modularity.

#159 -- this will link to issue 159

Review checklist

I have:
- followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/
- followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/
- followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy
- checked that this PR does not duplicate an open PR.

In the Content, I have included 
- relevant unit tests, and integration tests, 
- appropriate docstrings on all functions, structs, and modules, and included relevant documentation.

----
- [x] I have read and checked the items on the review checklist.

Co-authored-by: Anna GL <gagnelandmanna@gmail.com>
mitraA90 pushed a commit that referenced this issue Dec 22, 2023
@bors @gagnelandmanna
Merge #185
a56f3ba 
185: Including new vulnerability and p to theta curves  r=kmdeck a=gagnelandmanna

## Purpose 
The purpose of this PR is to change the vulnerability curve (K(P)) and water retention curve (to convert between P and theta) used in plant hydraulics, as well as to add in the infrastructure for adding new models for this/allowing for modularity.

#159 -- this will link to issue 159

Review checklist

I have:
- followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/
- followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/
- followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy
- checked that this PR does not duplicate an open PR.

In the Content, I have included 
- relevant unit tests, and integration tests, 
- appropriate docstrings on all functions, structs, and modules, and included relevant documentation.

----
- [x] I have read and checked the items on the review checklist.

Co-authored-by: Anna GL <gagnelandmanna@gmail.com>
@kmdeck kmdeck mentioned this issue Feb 5, 2024
Closed
15 tasks
@kmdeck kmdeck mentioned this issue Apr 26, 2024
Open
1 task
@kmdeck kmdeck changed the title Misc improvements to plant hydraulics Improvements to plant hydraulics model Sep 12, 2024
@kmdeck kmdeck mentioned this issue Sep 12, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gagnelandmanna gagnelandmanna

@kmdeck kmdeck

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gagnelandmanna @kmdeck