Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ClimaLand README #679

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Update ClimaLand README #679

merged 1 commit into from
Jul 2, 2024

Conversation

AlexisRenchon
Copy link
Member

@AlexisRenchon AlexisRenchon commented Jun 26, 2024

Purpose

This PR modernizes the README of the root of this repo.

Have a look at how it renders here

TO DO:

(go ahead and edit this post to add to do list)

@AlexisRenchon AlexisRenchon added the documentation Improvements or additions to documentation label Jun 26, 2024
@braghiere
Copy link
Member

Couple of comments: I would change this:

"Certain features, including global runs, are not currently available on Windows due to limitations with our regridding software."

to

"Certain features are not currently available on Windows."

Also, there two new papers to be added on the list:

Braghiere, R. K., Wang, Y., Gagné-Landmann, A., Brodrick, P. G., Bloom, A. A., Norton, A. J., Ma, S., Levine, P., Longo, M., Deck, K., Gentine, P., Worden, J. R., Frankenberg, C., & Schneider, T. (2023). The Importance of Hyperspectral Soil Albedo Information for Improving Earth System Model Projections. AGU Advances, 4(4), e2023AV000910. https://doi.org/10.1029/2023AV000910

Wang, Y., Braghiere, R. K., Yin, Y., Yao, Y., Hao, D., & Frankenberg, C. (2024). Beyond the visible: Accounting for ultraviolet and far-red radiation in vegetation productivity and surface energy budgets. Global Change Biology, 30(5), e17346. https://doi.org/10.1111/GCB.17346

@Sbozzolo
Copy link
Member

Couple of comments: I would change this:

"Certain features, including global runs, are not currently available on Windows due to limitations with our regridding software."

to

"Certain features are not currently available on Windows."

Actually, now everything is available on windows because we don't use tempestremap anymore

@juliasloan25
Copy link
Member

It seems pretty technical to include all of our abstract model types under "Models", e.g. AbstractImExModel and AbstractModel. Maybe we could reword this section to explain each of the model types in words instead of explaining the type hierarchy

README.md Outdated Show resolved Hide resolved
- ClimaLand has a modular design, models can be run as standalone (e.g., soil moisture only) or integrated (e.g., soil moisture and energy AND canopy AND snow, etc.)
- ClimaLand is CPU and GPU compatible
- ClimaLand welcome contributions: we welcome users to create a branch and extend our code. For example, a modeler might want to test a new stomatal conductance model.
- ClimaLand provides APIs and UIs at multiple levels.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean by multiple levels?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right this isn't clear... I meant for example ClimaLand and ClimaLandSimulations API, where you need to go in details or not to run a simulation, for example. (I think ClimaLandSimulations is "higher level" because it does a lot of abstraction? Is this correct language to say this? I am not sure)

Should I just say "ClimaLand provides APIs and UIs?"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm you could say we provide APIs for model developers, as well as a higher-level user interface for running simulations?

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@AlexisRenchon AlexisRenchon requested a review from kmdeck July 2, 2024 16:26
@AlexisRenchon
Copy link
Member Author

@Sbozzolo
Did you want to fix the logo or make any other change to the README?

ALL:
What do you think of the table links, docs build, documentation, CI, code coverage, downloads: do we need all of them, do we want to modify something (eventually docs from dev to stable?), do we want to add something (maybe CliMA website?)

@kmdeck
Copy link
Member

kmdeck commented Jul 2, 2024

@Sbozzolo Did you want to fix the logo or make any other change to the README?

ALL: What do you think of the table links, docs build, documentation, CI, code coverage, downloads: do we need all of them, do we want to modify something (eventually docs from dev to stable?), do we want to add something (maybe CliMA website?)

I think the only change I would make is to remove the docs build, it's not very interesting even to us I think :) I think CI and code coverage are important to have.

I think this PR is ready to go and we can add in the docs dev -> stable change when that is available?

README.md Outdated

CanopyModel <: AbstractVegetationModel <: AbstractExpModel <: AbstractModel [runnable w/o LandModel wrapper as well]
- RichardsModel <: AbstractSoilModel <: AbstractModel (runnable in standalone mode, or as part of a land model)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one small comment here - RichardsModel currently only runs in standalone. not sure if we would want it ever in a land model since it doesnt have temperature and phase change in soil?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no you're right, we don't need it in land model. I'll update to "runnable only in standalone mode"

@AlexisRenchon
Copy link
Member Author

I am merging this, @Sbozzolo just make a new PR if you want to modify or add anything to the README?

The old readme was not well structured and missing some info.
This PR is a first step to clean things.
@AlexisRenchon AlexisRenchon merged commit 50f9640 into main Jul 2, 2024
10 checks passed
@AlexisRenchon AlexisRenchon deleted the ar/update_readme branch October 21, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants