add ClimaCoupler downstream test #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasloan25
force-pushed
the
js/downstream
branch
from
c619d9b
to
460e6d6
Compare
Sbozzolo
reviewed
Jun 27, 2024
Sbozzolo
reviewed
Jun 27, 2024
Sbozzolo
reviewed
Jun 27, 2024
Sbozzolo
approved these changes
Jun 27, 2024
Comment on lines
+31
to
+38
| julia --color=yes --project=ClimaCoupler.jl/experiments/ClimaEarth/ -e 'using Pkg; Pkg.instantiate()' | ||
| julia --color=yes --project=ClimaCoupler.jl/experiments/ClimaEarth/ -e 'using Pkg; Pkg.develop(; path = ".")' | ||
| julia --color=yes --project=ClimaCoupler.jl/experiments/ClimaEarth/ ClimaCoupler.jl/experiments/ClimaEarth/run_amip.jl --config_file ClimaCoupler.jl/config/ci_configs/target_amip_albedo_function.yml --job_id target_amip_albedo_function |
There was a problem hiding this comment.
Ideally, we would want to have a leaner test. For example, the ClimaEarth env is already massive and takes a long time to instantiate.
It's fine for the time bein
juliasloan25
force-pushed
the
js/downstream
branch
from
88fd35b
to
b270277
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
It would be useful to have a driver that runs a simple coupled ClimaAtmos/ClimaLand setup for one or two timesteps. This could be used by these packages to test the effects of changes downstream in ClimaCoupler. It wouldn't test physical stability, but it would test interface changes
see CliMA/ClimaCoupler.jl#877
To-do
It would be good to have a more streamlined test that doesn't require instantiating the entire
ClimaEarthenvironment, but for now this is fineContent