Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClimaLand Diagnostics, update #682

Closed
wants to merge 4 commits into from
Closed

ClimaLand Diagnostics, update #682

wants to merge 4 commits into from

Conversation

AlexisRenchon
Copy link
Member

Purpose

This is a second major PR to introduce diagnostics in ClimaLand.

To do:

  • union type ::BucketModel, ::SoilCanopyModel
  • more tests
  • better docs
  • macro to reduce code duplication in compute_ and add_diag ( ? )
  • fix names, units, comments of SoilCanopyModel diagnostics variables
  • add more default methods, period of averaging, what variables, etc.

@AlexisRenchon AlexisRenchon added the enhancement New feature or request label Jun 28, 2024
@AlexisRenchon
Copy link
Member Author

@Sbozzolo just listing our to do list for now.

@AlexisRenchon AlexisRenchon mentioned this pull request Jul 3, 2024
Merged
1 task
@AlexisRenchon AlexisRenchon deleted the ar/diagnostics_second branch October 21, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Sbozzolo Sbozzolo

@AlexisRenchon AlexisRenchon

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexisRenchon @Sbozzolo