-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix buildkite run so that unit tests run on GPU #739
Draft
kmdeck
wants to merge
3
commits into
main
Choose a base branch
from
kd/buildkite_fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
force-pushed
the
kd/buildkite_fix
branch
2 times, most recently
from
August 29, 2024 19:11
bf8038c
to
309d6f3
Compare
kmdeck
force-pushed
the
kd/buildkite_fix
branch
from
September 18, 2024 18:38
309d6f3
to
74e15a2
Compare
@charleskawczynski do you have any ideas about the bug up above? I can reproduce the error, and I tried added more parametric types to the
Im trying to use @code_warntype in the REPL but am not clearly seeing any "Any" pop up:
|
I pushed a commit! I think the issue was that we were reaching into global scope for the default argument |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Some of our buildkite runs were not running on GPU. Update buildkite so that they are.
To-do
experiments/integrated/performance/profile_allocations.jl
. Note that the same code runs on the Clima cluster on GPU. This is the error message:/central/home/kdeck/ClimaLand.jl/src/standalone/Soil/soil_heat_parameterizations.jl:65:
Called by:
Note that
typeof(hydrology_cm) <: AbstractSoilHydrologyClosure
and we have setBase.broadcastable(x::AbstractSoilHydrologyClosure) = tuple(x)
Content