Extend plant hydraulics rooting depth to support fields #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PlantHydraulicsParameters previously held a root distribution function that had a default value for rooting depth. This function is always the same outside testing, so it was removed as a parameter and placed into src. rooting_depth, an argument to the distribution function is now a parameters that is either a Float or a field. The tests are changed to check passing rooting_depth as a float or a field of floats that are the same everywhere. One test in plant_hydraulics_test.jl only checks the case of when rooting_depth is a float because changing to a field requires extensive changes to the entire test.
The test solves a system of functions which is defined in initial_compute_expected_tendecy!. That function is now changed to support fields, but each equation in the system of equations still outputs a scalar. This is done by taking a mean across the resulting field. This is done because NLsolve does not work of equations on fields.
longruns/land.jl, benchmarks/land.jl and longruns/land_regional.jl are changed to use the root depth map from the clm data
imreddyTeja
force-pushed
the
tr/extend-plant-hydraulics-root
branch
from
c19eb7e
to
7f28b39
Compare
Sbozzolo
reviewed
Sep 20, 2024
Comment on lines
+9
to
+11
| - ![][badge-💥breaking] Remove root_distribution from PlantHydraulicsParameters and add rooting_depth, | ||
| which supports fields | ||
| PR[#783](https://github.com/CliMA/ClimaLand.jl/pull/783) |
There was a problem hiding this comment.
If something is breaking, it is always a good idea to describe how it is breaking and what users might need to do to fix it
| ), | ||
| ) * AI[plant_hydraulics.compartment_labels[i]] | ||
| end | ||
| F[i] = mean(fa .- T0A) |
There was a problem hiding this comment.
Let's discuss this. I would have expected F to be a Field here too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Towards spatially varying canopy parameters
Move the root_distribution function to src
Make rooting_depth, an argument to root_distribution, a parameter of PlantHydraulicsParameters
Make rooting depth support ClimaCore fields.
Closes #772
PlantHydraulicsParameters previously held a root distribution function
that had a default value for rooting depth. This function is
always the same outside testing, so it was removed as a parameter
and placed into src. rooting_depth, an argument to the distribution function
is now a parameters that is either a Float or a field. The tests are changed to
check passing rooting_depth as a float or a field of floats that are the same everywhere.
To-do
Content
PlantHydraulicsParameters previously held a root distribution function
that had a default value for rooting depth. This function is
always the same outside testing, so it was removed as a parameter
and placed into src. rooting_depth, an argument to the distribution function
is now a parameters that is either a Float or a field. The tests are changed to
check passing rooting_depth as a float or a field of floats that are the same everywhere.
The rooting_depth map can be seen here: