Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClimaCore downstream tests are failing #303

Closed
Sbozzolo opened this issue Jul 2, 2024 · 1 comment
Closed

ClimaCore downstream tests are failing #303

Sbozzolo opened this issue Jul 2, 2024 · 1 comment

Comments

@Sbozzolo
Copy link
Member

Sbozzolo commented Jul 2, 2024

https://github.com/CliMA/ClimaCore.jl/actions/runs/9763942270/job/26951021951?pr=1852

Seems like an easy error to fix:

Stale dependencies: Test Failed at /home/runner/.julia/packages/Aqua/tHrmY/src/stale_deps.jl:31
  Expression: isempty(stale_deps)
   Evaluated: isempty(Base.PkgId[ClimaCore [d414da3d-4745-48bb-8d80-42e94e092884]])

Stacktrace:
 [1] macro expansion
   @ /opt/hostedtoolcache/julia/1.10.4/x64/share/julia/stdlib/v1.10/Test/src/Test.jl:672 [inlined]
 [2] test_stale_deps(pkg::Base.PkgId; kwargs::@Kwargs{})
   @ Aqua ~/.julia/packages/Aqua/tHrmY/src/stale_deps.jl:31
 [3] test_stale_deps
   @ ~/.julia/packages/Aqua/tHrmY/src/stale_deps.jl:29 [inlined]
 [4] #test_stale_deps#38
   @ ~/.julia/packages/Aqua/tHrmY/src/stale_deps.jl:35 [inlined]
 [5] test_stale_deps
   @ ~/.julia/packages/Aqua/tHrmY/src/stale_deps.jl:34 [inlined]
 [6] macro expansion
   @ ~/.julia/packages/Aqua/tHrmY/src/Aqua.jl:90 [inlined]
 [7] macro expansion
   @ /opt/hostedtoolcache/julia/1.10.4/x64/share/julia/stdlib/v1.10/Test/src/Test.jl:1577 [inlined]
 [8] test_all(testtarget::Module; ambiguities::Bool, unbound_args::Bool, undefined_exports::Bool, project_extras::Bool, stale_deps::Bool, deps_compat::Bool, piracies::Bool, persistent_tasks::Bool)
   @ Aqua ~/.julia/packages/Aqua/tHrmY/src/Aqua.jl:89
ClimaTimeSteppers [595c0a79-7f3d-439a-bc5a-b232dc3bde79] does not declare a compat entry for the following deps:
1-element Vector{Base.PkgId}:
 ClimaCore [d414da3d-4745-48bb-8d80-42e94e092884]
ClimaTimeSteppers [595c0a79-7f3d-439a-bc5a-b232dc3bde79] deps: Test Failed at /home/runner/.julia/packages/Aqua/tHrmY/src/deps_compat.jl:60
  Expression: isempty(result)
   Evaluated: isempty(Base.PkgId[ClimaCore [d414da3d-4745-48bb-8d80-42e94e092884]])

Stacktrace:
 [1] macro expansion
   @ /opt/hostedtoolcache/julia/1.10.4/x64/share/julia/stdlib/v1.10/Test/src/Test.jl:672 [inlined]
 [2] test_deps_compat(pkg::Base.PkgId, deps_type::String; broken::Bool, kwargs::@Kwargs{})
   @ Aqua ~/.julia/packages/Aqua/tHrmY/src/deps_compat.jl:60
 [3] test_deps_compat
   @ ~/.julia/packages/Aqua/tHrmY/src/deps_compat.jl:55 [inlined]
 [4] macro expansion
   @ ~/.julia/packages/Aqua/tHrmY/src/deps_compat.jl:41 [inlined]
 [5] macro expansion
   @ /opt/hostedtoolcache/julia/1.10.4/x64/share/julia/stdlib/v1.10/Test/src/Test.jl:1577 [inlined]
 [6] test_deps_compat(pkg::Base.PkgId; check_julia::Bool, check_extras::Bool, check_weakdeps::Bool, kwargs::@Kwargs{})
   @ Aqua ~/.julia/packages/Aqua/tHrmY/src/deps_compat.jl:41
Test Summary:                                                           | Pass  Fail  Total   Time
Aqua                                                                    |    9     2     11  40.0s
  Aqua tests (performance)                                              |    1            1   0.4s
  Aqua tests (remaining)                                                |    8     2     10  39.6s
    Method ambiguity                                                    |              None   0.0s
    Unbound type parameters                                             |    1            1   0.0s
    Undefined exports                                                   |    1            1   0.0s
    Compare Project.toml and test/Project.toml                          |    1            1   0.1s
    Stale dependencies                                                  |          1      1   3.4s
    Compat bounds                                                       |    3     1      4   1.1s
      julia                                                             |    1            1   0.0s
      ClimaTimeSteppers [595c0a79-7f3d-439a-bc5a-b232dc3bde79] deps     |          1      1   1.1s
      ClimaTimeSteppers [595c0a79-7f3d-439a-bc5a-b232dc3bde79] extras   |    1            1   0.0s
      ClimaTimeSteppers [595c0a79-7f3d-439a-bc5a-b232dc3bde79] weakdeps |    1            1   0.0s
    Piracy                                                              |    1            1   0.1s
    Persistent tasks                                                    |    1            1  32.5s
ERROR: LoadError: Some tests did not pass: 9 passed, 2 failed, 0 errored, 0 broken.
in expression starting at /home/runner/work/ClimaCore.jl/ClimaCore.jl/ClimaTimeSteppers.jl/test/runtests.jl:28
ERROR: Package ClimaTimeSteppers errored during testing
Stacktrace:
 [1] pkgerror(msg::String)
   @ Pkg.Types /opt/hostedtoolcache/julia/1.10.4/x64/share/julia/stdlib/v1.10/Pkg/src/Types.jl:70
 [2] test(ctx::Pkg.Types.Context, pkgs::Vector{Pkg.Types.PackageSpec}; coverage::Bool, julia_args::Cmd, test_args::Cmd, test_fn::Nothing, force_latest_compatible_version::Bool, allow_earlier_backwards_compatible_versions::Bool, allow_reresolve::Bool)
   @ Pkg.Operations /opt/hostedtoolcache/julia/1.10.4/x64/share/julia/stdlib/v1.10/Pkg/src/Operations.jl:2019
 [3] test
   @ /opt/hostedtoolcache/julia/1.10.4/x64/share/julia/stdlib/v1.10/Pkg/src/Operations.jl:1900 [inlined]
 [4] test(ctx::Pkg.Types.Context, pkgs::Vector{Pkg.Types.PackageSpec}; coverage::Bool, test_fn::Nothing, julia_args::Cmd, test_args::Cmd, force_latest_compatible_version::Bool, allow_earlier_backwards_compatible_versions::Bool, allow_reresolve::Bool, kwargs::@Kwargs{io::IOContext{Base.PipeEndpoint}})
   @ Pkg.API /opt/hostedtoolcache/julia/1.10.4/x64/share/julia/stdlib/v1.10/Pkg/src/API.jl:444
 [5] test(pkgs::Vector{Pkg.Types.PackageSpec}; io::IOContext{Base.PipeEndpoint}, kwargs::@Kwargs{})
   @ Pkg.API /opt/hostedtoolcache/julia/1.10.4/x64/share/julia/stdlib/v1.10/Pkg/src/API.jl:159
 [6] test(pkgs::Vector{Pkg.Types.PackageSpec})
   @ Pkg.API /opt/hostedtoolcache/julia/1.10.4/x64/share/julia/stdlib/v1.10/Pkg/src/API.jl:148
 [7] test(; name::Nothing, uuid::Nothing, version::Nothing, url::Nothing, rev::Nothing, path::Nothing, mode::Pkg.Types.PackageMode, subdir::Nothing, kwargs::@Kwargs{})
   @ Pkg.API /opt/hostedtoolcache/julia/1.10.4/x64/share/julia/stdlib/v1.10/Pkg/src/API.jl:174
 [8] test()
   @ Pkg.API /opt/hostedtoolcache/julia/1.10.4/x64/share/julia/stdlib/v1.10/Pkg/src/API.jl:165
 [9] top-level scope
   @ none:1
@Sbozzolo
Copy link
Member Author

Found the issue and fixed it here: CliMA/ClimaCore.jl#1941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant