Fix ClimaTimeSteppers downstream test #1941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
force-pushed
the
gb/add_kinematicdriver
branch
3 times, most recently
from
5dade6a
to
7b7f32b
Compare
The ClimaTimeSteppers was failing because the test suite for ClimaTimeSteppers depends on ClimaCore, but not ClimaTimeSteppers itself. So, when we dev ClimaCore in ClimaTimeSteppers, `aqua` complains thatwe never use ClimaCore.
Sbozzolo
force-pushed
the
gb/add_kinematicdriver
branch
from
7b7f32b
to
08b6ef2
Compare
charleskawczynski
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ClimaTimeSteppers was failing because the test suite for ClimaTimeSteppers depends on ClimaCore, but ClimaTimeSteppers itself does not depend on ClimaCore. So, when we
devClimaCore in ClimaTimeSteppers,aquacomplains that we never use ClimaCore.