Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add broken test for inference failure in callbacks loop #317

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Add broken test for inference failure in callbacks loop #317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 31 additions & 6 deletions perf/jet.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using ArgParse, JET, Test, BenchmarkTools, DiffEqBase, ClimaTimeSteppers
# using Revise; include("perf/jet.jl")
using ArgParse, JET, Test, BenchmarkTools, SciMLBase, ClimaTimeSteppers
import ClimaTimeSteppers as CTS
function parse_commandline()
s = ArgParse.ArgParseSettings()
Expand All @@ -15,10 +16,29 @@ end
cts = joinpath(dirname(@__DIR__));
include(joinpath(cts, "test", "problems.jl"))
config_integrators(itc::IntegratorTestCase) = config_integrators(itc.prob)

struct Foo end
foo!(integrator) = nothing
(::Foo)(integrator) = foo!(integrator)
struct Bar end
bar!(integrator) = nothing
(::Bar)(integrator) = bar!(integrator)

function discrete_cb(cb!, n)
cond = if n == 1
(u, t, integrator) -> isnothing(cb!(integrator))
else
(u, t, integrator) -> isnothing(cb!(integrator)) || rand() ≤ 0.5
end
SciMLBase.DiscreteCallback(cond, cb!;)
end
function config_integrators(problem)
algorithm = CTS.IMEXAlgorithm(ARS343(), NewtonsMethod(; max_iters = 2))
dt = 0.01
integrator = DiffEqBase.init(problem, algorithm; dt)
discrete_callbacks = (discrete_cb(Foo(), 0), discrete_cb(Bar(), 0), discrete_cb(Foo(), 1), discrete_cb(Bar(), 1))
callback = SciMLBase.CallbackSet((), discrete_callbacks)

integrator = SciMLBase.init(problem, algorithm; dt, callback)
integrator.cache = CTS.init_cache(problem, algorithm)
return (; integrator)
end
Expand All @@ -33,7 +53,12 @@ else
end
(; integrator) = config_integrators(prob)

CTS.step_u!(integrator, integrator.cache) # compile first, and make sure it runs
step_allocs = @allocated CTS.step_u!(integrator, integrator.cache)
@show step_allocs
JET.@test_opt CTS.step_u!(integrator, integrator.cache)
@testset "JET / allocations" begin
CTS.step_u!(integrator, integrator.cache) # compile first, and make sure it runs
step_allocs = @allocated CTS.step_u!(integrator, integrator.cache)
@show step_allocs
JET.@test_opt CTS.step_u!(integrator, integrator.cache)

CTS.__step!(integrator) # compile first, and make sure it runs
JET.@test_opt broken = true CTS.__step!(integrator)
end
Loading