Skip to content
This repository has been archived by the owner on Mar 1, 2023. It is now read-only.

Add thermo mixing ratio functions #1928

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Add thermo mixing ratio functions #1928

merged 1 commit into from
Jan 14, 2021

Conversation

charleskawczynski
Copy link
Member

@charleskawczynski charleskawczynski commented Jan 14, 2021

Description

Add thermo method shum_to_mixing_ratio for computing mixing ratios (needed for radiation). I've also added a convenience method, mixing_ratios, which accepts a PhasePartition, and returns a PhasePartition of mixing ratios.

  • Code follows the style guidelines OR N/A.
  • Unit tests are included OR N/A.
  • Code is exercised in an integration test OR N/A.
  • Documentation has been added/updated OR N/A.

Copy link
Contributor

@tapios tapios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@szy21 Would you mind double-checking that this is correct?

@szy21
Copy link
Member

szy21 commented Jan 14, 2021

Looks good to me, thanks!

@charleskawczynski
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 14, 2021

@bors bors bot merged commit 65a7e65 into master Jan 14, 2021
@bors bors bot deleted the ck/mix_ratio branch January 14, 2021 21:30
yairchn pushed a commit that referenced this pull request Jan 15, 2021
1928: Add thermo mixing ratio functions r=charleskawczynski a=charleskawczynski

Add thermo method `shum_to_mixing_ratio` for computing mixing ratios (needed for radiation). I've also added a convenience method, `mixing_ratios`, which accepts a `PhasePartition`, and returns a `PhasePartition` of mixing ratios.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants