Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-equilibrium parcel example #433

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

non-equilibrium parcel example #433

wants to merge 35 commits into from

Conversation

oalcabes
Copy link
Contributor

@oalcabes oalcabes commented Aug 7, 2024

Purpose

Non-equilibrium initial formulation for parcel model

To-do

Content

  • I have read and checked the items on the review checklist.

Olivia Alcabes added 27 commits August 7, 2024 14:19
changing the parcel model to incorporate nonequilibrium physics
5e597b2
got the parcel running with non eq
9f70bba
changes fixing input parameters for simple non equilibrium formulation
4e750c1
adding functionality for more complicated noneq formulation
abcdec4
Got the complicated noneq formulation working
ac0e865
simple version of formulation no dqdT no Ac
cf8651d
added functionality for Ac (but not dqdT yet)
c22a069
fixed dqsldT
7e27f44
adding q_ice functionality
dd7527d
finalizing liquid non equilibrium parcel
49bfbaa
renaming nonequilibrium liquid example
0989df3
modifications for deposition functionality
cb9b303
non equilibrium formulation will now grow ice
7444527
Made plots nicer
2239f24
got both simple formulation and complex formulation of non equilibriu…
f8163bb 
…m working
fixed e_sat issue
8b376fe
changed formulation to dqdt
619a5c2
fixed bug that was causing growth without supersaturation
d4e8f77
added non time integrator version of M&M
22c3558
first draft of nonequilibrium formulation docs
89c3bee
non eq docs draft 2
3a2b421
changed to correct tau values for M&M simple form
5bac6ba
noneq docs draft 3
d618ef7
cleaned up
d4d0c19
added additional 2008 morrison & growboski paper
c8317ee
adding documentation
51a95f9
cleaning
248996e
@oalcabes oalcabes self-assigned this Aug 7, 2024
@trontrytel trontrytel mentioned this pull request Aug 12, 2024
Closed
@trontrytel trontrytel mentioned this pull request Aug 15, 2024
Merged
@trontrytel
Copy link
Member

Lets split this PR into two, if thats ok:

  • first one that adds the time integrators version to our source code, docs and tests
  • second one that adds an example to parcel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trontrytel trontrytel Awaiting requested review from trontrytel

Assignees

@oalcabes oalcabes

Labels
Ice ⛄
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oalcabes @trontrytel