Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P3 collisions #442

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

P3 collisions #442

wants to merge 7 commits into from

Conversation

rorlija1
Copy link
Contributor

@rorlija1 rorlija1 commented Aug 19, 2024

  • PR with geometric collision kernel between ice and liquid particles.
  • Also attempted to implement collisions in src, but I have many doubts... I also did not have the chance to add any docs for collisions... see my comments and ask me anything! I used some of Anastasia's old code but changed/added things from MM2015, Cholette 2019, and Musil 1970 (a paper they reference).
  • The rates run in KiD but very very slowly...

@rorlija1 rorlija1 added the P3 label Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.81%. Comparing base (05e2b1c) to head (4de3a31).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #442   +/-   ##
=======================================
  Coverage   96.80%   96.81%           
=======================================
  Files          41       41           
  Lines        1442     1445    +3     
=======================================
+ Hits         1396     1399    +3     
  Misses         46       46           
Components Coverage Δ
src 98.73% <100.00%> (+<0.01%) ⬆️
ext 69.79% <ø> (ø)

@rorlija1 rorlija1 changed the title P3 collision kernel P3 collisions Aug 30, 2024
@rorlija1 rorlija1 changed the title P3 collisions P3 collisions :bowtie: Aug 30, 2024
@rorlija1 rorlija1 changed the title P3 collisions :bowtie: P3 collisions :bowtie Aug 30, 2024
@rorlija1 rorlija1 changed the title P3 collisions :bowtie P3 collisions :bowtie: Aug 30, 2024
@rorlija1 rorlija1 changed the title P3 collisions :bowtie: P3 collisions Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant