Refactor of some stretched rectilinear grid tests #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navidcy
reviewed
Feb 10, 2023
navidcy
reviewed
Feb 10, 2023
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
navidcy
reviewed
Feb 10, 2023
navidcy
approved these changes
Feb 10, 2023
tomchor
changed the title
tomchor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that in a couple of tests in
test_grids.jlthe code was written in way that leads to some not-so-clear statements such as:Oceananigans.jl/test/test_grids.jl
Line 381 in 182e75c
The above seems wrong at first but it's actually correct since
Δzᵃᵃᶜ()is defined the same way asgrid.Δzᵃᵃᶠ.This PR changes that to make the notation clearer (i.e.
grid.Δzᵃᵃᶠ[2:Nz] == Δzᵃᵃᶠ.(2:Nz)) and condenses 3 separate test functions for stretched grids (needing three separate grid instantiations) into one function (with the same tests).EDIT:
This also implements a suggestion by @glwagner in #2865 that couldn't be implemented then. I'll open another PR in the near future to further condense some other tests.