-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
aa274c1
commit 15a62d5
Showing
3 changed files
with
40 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
using Test | ||
using Thermodynamics | ||
using Aqua | ||
|
||
@testset "Aqua tests (performance)" begin | ||
# This tests that we don't accidentally run into | ||
# https://github.com/JuliaLang/julia/issues/29393 | ||
ua = Aqua.detect_unbound_args_recursively(Thermodynamics) | ||
@test length(ua) == 0 | ||
|
||
# See: https://github.com/SciML/OrdinaryDiffEq.jl/issues/1750 | ||
# Test that we're not introducing method ambiguities across deps | ||
ambs = Aqua.detect_ambiguities(Thermodynamics; recursive = true) | ||
pkg_match(pkgname, pkdir::Nothing) = false | ||
pkg_match(pkgname, pkdir::AbstractString) = occursin(pkgname, pkdir) | ||
filter!(x -> pkg_match("Thermodynamics", pkgdir(last(x).module)), ambs) | ||
|
||
# If the number of ambiguities is less than the limit below, | ||
# then please lower the limit based on the new number of ambiguities. | ||
# We're trying to drive this number down to zero to reduce latency. | ||
# Uncomment for debugging: | ||
for method_ambiguity in ambs | ||
@show method_ambiguity | ||
end | ||
@test length(ambs) ≤ 0 | ||
end | ||
|
||
@testset "Aqua tests (additional)" begin | ||
Aqua.test_undefined_exports(Thermodynamics) | ||
Aqua.test_stale_deps(Thermodynamics) | ||
Aqua.test_deps_compat(Thermodynamics) | ||
Aqua.test_project_extras(Thermodynamics) | ||
Aqua.test_project_toml_formatting(Thermodynamics) | ||
Aqua.test_piracy(Thermodynamics) | ||
end | ||
|
||
nothing |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters