Skip to content

Commit

Permalink
Merge pull request #201 from CliMA/dy/even_more_dual_fixes
Browse files Browse the repository at this point in the history 
Add more promotion and remove restriction on SA tolerance
  • Loading branch information
@charleskawczynski
charleskawczynski authored Feb 22, 2024
2 parents 16b1f86 + 56762c9 commit 6bf8059
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Thermodynamics"
uuid = "b60c26fb-14c3-4610-9d3e-2d17fe7ff00c"
authors = ["Climate Modeling Alliance"]
version = "0.12.1"
version = "0.12.2"

[deps]
DocStringExtensions = "ffbed154-4ef7-542d-bbb7-c09d3a79fcae"
Expand Down
12 changes: 7 additions & 5 deletions src/relations.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -834,6 +834,8 @@ isobaric specific heat capacities of the two phases, given
T_0 = TP.T_0(param_set)
return LH_0 + Δcp * (T - T_0)
end
latent_heat_generic(param_set, T, LH_0, Δcp) =
latent_heat_generic(param_set, promote(T, LH_0, Δcp)...)

"""
weighted_latent_heat(param_set, T, λ)
Expand Down Expand Up @@ -1568,7 +1570,7 @@ See also [`saturation_adjustment`](@ref).
q_tot::FT,
::Type{phase_type},
maxiter::Int,
relative_temperature_tol::FT,
relative_temperature_tol::Real,
T_guess::Union{FT, Nothing} = nothing,
) where {FT <: Real, sat_adjust_method, phase_type <: PhaseEquil}
_T_min = TP.T_min(param_set)
Expand Down Expand Up @@ -1708,7 +1710,7 @@ See also [`saturation_adjustment`](@ref).
q_tot::FT,
::Type{phase_type},
maxiter::Int,
relative_temperature_tol::FT,
relative_temperature_tol::Real,
T_guess::Union{FT, Nothing} = nothing,
) where {FT <: Real, sat_adjust_method, phase_type <: PhaseEquil}
_T_min = TP.T_min(param_set)
Expand Down Expand Up @@ -1813,7 +1815,7 @@ See also [`saturation_adjustment`](@ref).
q_tot::FT,
::Type{phase_type},
maxiter::Int,
relative_temperature_tol::FT,
relative_temperature_tol::Real,
T_guess::Union{FT, Nothing} = nothing,
) where {FT <: Real, sat_adjust_method, phase_type <: PhaseEquil}
_T_min = TP.T_min(param_set)
Expand Down Expand Up @@ -1925,7 +1927,7 @@ See also [`saturation_adjustment`](@ref).
q_tot::FT,
::Type{phase_type},
maxiter::Int,
relative_temperature_tol::FT = sqrt(eps(FT)),
relative_temperature_tol::Real = sqrt(eps(FT)),
T_guess::Union{FT, Nothing} = nothing,
) where {FT <: Real, sat_adjust_method, phase_type <: PhaseEquil}
tol = RS.RelativeSolutionTolerance(relative_temperature_tol)
Expand Down Expand Up @@ -2124,7 +2126,7 @@ See also [`saturation_adjustment`](@ref).
q_tot::FT,
::Type{phase_type},
maxiter::Int,
relative_temperature_tol::FT,
relative_temperature_tol::Real,
T_guess::Union{FT, Nothing} = nothing,
) where {FT <: Real, sat_adjust_method, phase_type <: PhaseEquil}
tol = RS.RelativeSolutionTolerance(relative_temperature_tol)
Expand Down

2 comments on commit 6bf8059

@dennisYatunin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/101400

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.12.2 -m "<description of version>" 6bf8059d3bee99881c12eeab9c878f3e42a85a2c
git push origin v0.12.2

Please sign in to comment.