Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change temperature tolerance of all PhaseEquil constructor to 1e-4 #222

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

szy21
Copy link
Member

@szy21 szy21 commented Jul 19, 2024

Some small clean up, but hopefully it's an improvement.

@szy21 szy21 force-pushed the zs/temperature_tol branch 2 times, most recently from e2300fd to 77d116f Compare July 19, 2024 18:18
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.40%. Comparing base (245f5d8) to head (fdd3336).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #222   +/-   ##
=======================================
  Coverage   90.40%   90.40%           
=======================================
  Files           9        9           
  Lines        1167     1167           
=======================================
  Hits         1055     1055           
  Misses        112      112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szy21 szy21 added the Launch Buildkite Add label to launch Buildkite label Jul 19, 2024
@szy21 szy21 marked this pull request as ready for review July 19, 2024 20:19
Copy link
Member

@charleskawczynski charleskawczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look fine to me. Could we change the title to "Relax temperature tolerances"?

Also, maybe we can update the news? (we can add a precision changes expected note). This will ultimately result in fewer NL solver iterations at the expense of slightly less accurate solutions. That's what we're aiming to do, correct?

@szy21 szy21 changed the title clean up temperature tolerance relax temperature tolerance Jul 20, 2024
@szy21 szy21 changed the title relax temperature tolerance Change temperature tolerance of all PhaseEquil constructor to 1e-4 Jul 20, 2024
@szy21
Copy link
Member Author

szy21 commented Jul 20, 2024

Code changes look fine to me. Could we change the title to "Relax temperature tolerances"?

Also, maybe we can update the news? (we can add a precision changes expected note). This will ultimately result in fewer NL solver iterations at the expense of slightly less accurate solutions. That's what we're aiming to do, correct?

I changed the title and updated the news. I don't think we will see a difference in ClimaAtmos now as the constructor with a different tolerance is only used in some initial conditions. But we can expect changes in iterations if we further change the tolerance.

@szy21 szy21 added this pull request to the merge queue Jul 20, 2024
Merged via the queue into main with commit ffbbe72 Jul 20, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Launch Buildkite Add label to launch Buildkite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants