Make q non-optional so that FT is gauranteed to be inferred #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
added a commit
that referenced
this pull request
Aug 25, 2021
41: Add dependency on ExprTools to fix version r=charleskawczynski a=charleskawczynski Just ran into [GPUCompiler's 214](JuliaGPU/GPUCompiler.jl#214) in #40. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 25, 2021
40: Make q non-optional so that FT is gauranteed to be inferred r=charleskawczynski a=charleskawczynski `q` cannot be optional in these methods, because then `FT` is not inferable. Thanks for catching this, `@trontrytel.` Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
|
Build failed: |
bors bot
added a commit
that referenced
this pull request
Aug 25, 2021
41: Add dependency on ExprTools to fix version r=charleskawczynski a=charleskawczynski Just ran into [GPUCompiler's 214](JuliaGPU/GPUCompiler.jl#214) in #40. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot
added a commit
that referenced
this pull request
Aug 25, 2021
41: Add dependency on ExprTools to fix version r=charleskawczynski a=charleskawczynski Just ran into [GPUCompiler's 214](JuliaGPU/GPUCompiler.jl#214) in #40. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot
added a commit
that referenced
this pull request
Aug 25, 2021
41: Add dependency on ExprTools to fix version r=charleskawczynski a=charleskawczynski Just ran into [GPUCompiler's 214](JuliaGPU/GPUCompiler.jl#214) in #40. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
charleskawczynski
force-pushed
the
ck/bugfix
branch
from
8ab4d87
to
8f6936d
Compare
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qcannot be optional in these methods, because thenFTis not inferable. Thanks for catching this, @trontrytel.