Rename PhaseEquil outer constructor to PhaseEquil_ρeq, change arg order #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #47 +/- ##
=======================================
Coverage 97.67% 97.67%
=======================================
Files 7 7
Lines 775 775
=======================================
Hits 757 757
Misses 18 18
Continue to review full report at Codecov.
|
charleskawczynski
force-pushed
the
ck/rename_phase_equil
branch
from
b78b479
to
72a199e
Compare
|
bors r+ |
|
bors ping |
1 similar comment
|
bors ping |
|
pong |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
PhaseEquilouter constructor toPhaseEquil_ρeq(breaking for API changes)air_temperature_given_θρq->air_temperature_given_ρθqair_temperature_given_θpq->air_temperature_given_pθqThis will allow us to avoid method ambiguities between
PhaseEquilandPhaseEquil_ρeq.