Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve convergence plots #59

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Improve convergence plots #59

merged 1 commit into from
Jan 31, 2022

Conversation

charleskawczynski
Copy link
Member

@charleskawczynski charleskawczynski commented Oct 20, 2021 •
edited
Loading

This PR was pulled from ClimateMachine.jl's 1885, which improves the convergence plots for values outside of the tested profiles.

@trontrytel, we could add these same plots for the other thermo constructors to get an idea of the convergence manifold.

@charleskawczynski charleskawczynski added the documentation Improvements or additions to documentation label Oct 20, 2021
@charleskawczynski charleskawczynski mentioned this pull request Oct 20, 2021
Closed
4 tasks
@trontrytel
Copy link
Member

You mean to generate those plots but around the input profiles we encounter in TC.jl simulations for TRMM?

@codecov
Copy link

codecov bot commented Oct 20, 2021 •
edited
Loading

Codecov Report

Merging #59 (2a95c4a) into main (444247e) will decrease coverage by 0.55%.
The diff coverage is 0.00%.

❗ Current head 2a95c4a differs from pull request most recent head e34c03f. Consider uploading reports for the commit e34c03f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   96.26%   95.70%   -0.56%     
==========================================
  Files           7        7              
  Lines         856      861       +5     
==========================================
  Hits          824      824              
- Misses         32       37       +5
Impacted Files Coverage Δ
src/config_numerical_method.jl 61.64% <0.00%> (-4.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 444247e...e34c03f. Read the comment docs.

@charleskawczynski
Copy link
Member Author

You mean to generate those plots but around the input profiles we encounter in TC.jl simulations for TRMM?

Yeah, we could grab the extremes that we observe (and expect things to still work) and plot convergence in the box

@charleskawczynski
Copy link
Member Author

charleskawczynski commented Oct 20, 2021 •
edited
Loading

Hmmm, something is fishy. It's converging everywhere. There must be a bug.

Fixed, the order of arguments was initially incorrect.

@charleskawczynski charleskawczynski force-pushed the ck/convergence_plots branch 2 times, most recently from dce0ec2 to 1664cd2 Compare January 29, 2022 18:46
@charleskawczynski
Copy link
Member Author

Alright, I think this is ready, I'll merge the less controversial parts now, and open a separate PR for getting RegulaFalsi working.

@charleskawczynski
Improve convergence plots
e34c03f 
Adjust RegulaFalsi bounds

Fix docs, revert RegulaFalsi bounds
@charleskawczynski
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 31, 2022

Build succeeded:

@bors bors bot merged commit 5d5d41d into main Jan 31, 2022
@bors bors bot deleted the ck/convergence_plots branch January 31, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charleskawczynski @trontrytel