Use concrete phase types #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
|
bors r- |
|
Canceled. |
|
bors r+ |
|
Build failed: |
charleskawczynski
force-pushed
the
ck/improve_perf
branch
2 times, most recently
from
7bb0ef3
to
0cdc6c4
Compare
Codecov Report
@@ Coverage Diff @@
## main #71 +/- ##
==========================================
- Coverage 96.84% 96.84% -0.01%
==========================================
Files 7 7
Lines 857 855 -2
==========================================
- Hits 830 828 -2
Misses 27 27
Continue to review full report at Codecov.
|
Bump patch version number Remove ExprTools Try CUDA_VERSION 10.2 Only catch phase_type as type parameter Add pTq constructor analysis, fix 0 alloc case
charleskawczynski
force-pushed
the
ck/improve_perf
branch
from
0cdc6c4
to
4709361
Compare
|
bors r+ |
bors bot
added a commit
to CliMA/ClimaTimeSteppers.jl
that referenced
this pull request
Dec 5, 2022
93: Prep alleviating latency issues r=charleskawczynski a=charleskawczynski This PR takes a couple steps to tackle some latency issues: - [Avoid UnionAll::DataType in struct](52c9ff0), which was shown to improve inference [here](CliMA/Thermodynamics.jl#71), and a smaller MWE [here](https://gist.github.com/charleskawczynski/61efc7b769e14eab7231e686773b9d0e) - [Allow SparseContainers to work with Arrays](c5c53ee) Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help with allocations, since we make closures over these types, which are Unionall right now, this PR makes them concrete.