Bump ClimaParameters compat. #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilopezgp
force-pushed
the
bump_cp_compat
branch
from
de34242
to
76b77fa
Compare
Codecov Report
@@ Coverage Diff @@
## main #77 +/- ##
=======================================
Coverage 96.26% 96.26%
=======================================
Files 7 7
Lines 856 856
=======================================
Hits 824 824
Misses 32 32 Continue to review full report at Codecov.
|
charleskawczynski
approved these changes
Jan 12, 2022
There was a problem hiding this comment.
LGTM, but we'll need to wait for #76, which should fix our currently broken CI (due to a CUDA update)
|
Can we ignore the buildkite CI until the issue is resolved @charleskawczynski ? |
|
I'd prefer we fix CI first |
ilopezgp
force-pushed
the
bump_cp_compat
branch
from
76b77fa
to
74e876f
Compare
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.