Support configure System log table`s ttl in config.xml #17438
Conversation
robot-clickhouse
added
the
pr-improvement
spongedu
changed the title
programs/server/config.xml
Outdated
| @@ -589,6 +589,9 @@ | |||
| toStartOfHour(event_time) | |||
| --> | |||
| <partition_by>toYYYYMM(event_date)</partition_by> | |||
| <!-- How many days data would be kept. It works only when this option is opened and is set greater than 0. | |||
| --> | |||
| <ttl>30</ttl> | |||
There was a problem hiding this comment.
Let's name it <delete_after_days> or something, just <ttl> is too generic. Maybe we'll want to use it to accept generic TTL specification (or you can do it now if you wish, just paste it into table description).
There was a problem hiding this comment.
Let's name it
<delete_after_days>or something, just<ttl>is too generic. Maybe we'll want to use it to accept generic TTL specification (or you can do it now if you wish, just paste it into table description).
ok, I think we can keep it as and make it accept generic TTL specification.
src/Interpreters/SystemLog.cpp
Outdated
| @@ -65,6 +65,9 @@ std::shared_ptr<TSystemLog> createSystemLog( | |||
| engine = "ENGINE = MergeTree"; | |||
| if (!partition_by.empty()) | |||
| engine += " PARTITION BY (" + partition_by + ")"; | |||
| int ttl = config.getInt(config_prefix + ".ttl", 0); | |||
There was a problem hiding this comment.
Please also add a check to the above if, that if engine is specified manually, ttl must not be specified and must instead go into the engine specification. Like for <partition_by>.
There was a problem hiding this comment.
ok. Will fix here.
|
@akuzm Thanks for your review. I've made some updates according to our discussion. PTAL. |
|
The test failures are not related. This feature is very simple, but tricky to test, so I think we don't have to add a test for it. |
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Allow specifying TTL to remove old entries from system log tables, using the
<ttl>attribute inconfig.xml.