Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to BoringSSL (part 2) #18129

Merged
merged 25 commits into from
Dec 18, 2020
Merged

Port to BoringSSL (part 2) #18129

merged 25 commits into from
Dec 18, 2020

Conversation

alexey-milovidov
Copy link
Member

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Change OpenSSL to BoringSSL. It allows to avoid issues with sanitizers. This fixes #12490. This fixes #17502. This fixes #12952.

Continuation of #16043

@robot-clickhouse robot-clickhouse added pr-build Pull request with build/testing/packaging improvement submodule changed At least one submodule changed in this PR. labels Dec 16, 2020
@alexey-milovidov alexey-milovidov marked this pull request as ready for review December 16, 2020 23:02
@alexey-milovidov
Copy link
Member Author

Bonus: 6 times speedup.

@vzakaznikov
Copy link
Contributor

For the TestFlows check error below you need to bump version to 1.6.72. I already have a PR for that
#18208.

✘ 56m 34s   [ Error  ] /clickhouse
    AttributeError
    Traceback (most recent call last):
      File "regression.py", line 23, in <module>
        regression()
      File "regression.py", line 20, in regression
        Feature(test=load("aes_encryption.regression", "regression"))(**args)
      File "/usr/lib/python3.8/importlib/__init__.py", line 127, in import_module
        return _bootstrap._gcd_import(name[level:], package, level)
      File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
      File "<frozen importlib._bootstrap>", line 991, in _find_and_load
      File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
      File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
      File "<frozen importlib._bootstrap_external>", line 783, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/ClickHouse/tests/testflows/aes_encryption/regression.py", line 9, in <module>
        from aes_encryption.requirements import *
      File "/ClickHouse/tests/testflows/aes_encryption/requirements/__init__.py", line 1, in <module>
        from .requirements import *
      File "/ClickHouse/tests/testflows/aes_encryption/requirements/requirements.py", line 9, in <module>
        Heading = Specification.Heading
    AttributeError: type object 'Specification' has no attribute 'Heading'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build Pull request with build/testing/packaging improvement submodule changed At least one submodule changed in this PR.
Projects
None yet
3 participants