Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging TestFlows requirements for AES encryption functions. #18221

Conversation

vzakaznikov
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Merging requirements for AES encryption functions.
Updating aes_encryption tests to use new requirements.
Updating TestFlows version to 1.6.72.

Detailed description / Documentation draft:
Merging requirements for AES encryption functions.
Updating aes_encryption tests to use new requirements.
Updating TestFlows version to 1.6.72.

Updating aes_encryption tests to use new requirements.
Updating TestFlows version to 1.6.72.
@robot-clickhouse robot-clickhouse added the pr-build Pull request with build/testing/packaging improvement label Dec 18, 2020
@alexey-milovidov
Copy link
Member

Could you please resolve conflicts?

…o simplify_testflows_aes_encryption_requirements
@vzakaznikov
Copy link
Contributor Author

Could you please resolve conflicts?

Done, but still need to check tests and remove CFB1 and CFB8 modes that are no longer supported.

@alexey-milovidov alexey-milovidov self-assigned this Dec 19, 2020
@vzakaznikov
Copy link
Contributor Author

@alexey-milovidov, for GCM mode the IV is expected to be 12 bytes based on the error message but there is no error when it less than 12. Is this the expected behavior?

user-host :) SELECT encrypt('aes-192-gcm', 'hello', '123456789012345612345678')
SELECT encrypt('aes-192-gcm', 'hello', '123456789012345612345678')
Query id: d8a7d263-57f1-43b4-a297-1cdff19ae21f

Received exception from server (version 20.13.1):
Code: 36. DB::Exception: Received from localhost:9000. DB::Exception: Invalid IV size 0 != expected size 12: While processing encrypt('aes-192-gcm', 'hello', '123456789012345612345678'). 

0 rows in set. Elapsed: 0.003 sec. 

user-host :) SELECT encrypt('aes-192-gcm', 'hello', '123456789012345612345678', '1')
SELECT encrypt('aes-192-gcm', 'hello', '123456789012345612345678', '1')
Query id: 0a996378-9839-4b21-8b27-0da3a1d461e0

┌─encrypt('aes-192-gcm', 'hello', '123456789012345612345678', '1')─┐
│ ߈̺<v�R�oމ�c7JS�t
└──────────────────────────────────────────────────────────────────┘

1 rows in set. Elapsed: 0.003 sec.

user-host :)

@vzakaznikov
Copy link
Contributor Author

@alexey-milovidov, I've updated requirements and tests. When TestFlows check is green this PR is ready for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build Pull request with build/testing/packaging improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants