Drop helping tables when the whole table is done in clickhouse-copier #19743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
mdianjun
force-pushed
the
fix-bug-for-copier
branch
from
478e823
to
1507caa
Compare
|
I'm confused why |
mdianjun
force-pushed
the
fix-bug-for-copier
branch
from
1507caa
to
d5ba2e3
Compare
|
@nikitamikhaylov PTAL. |
mdianjun
force-pushed
the
fix-bug-for-copier
branch
from
d5ba2e3
to
113a03b
Compare
mdianjun
force-pushed
the
fix-bug-for-copier
branch
from
113a03b
to
198a8d3
Compare
Our AST Fuzzer processes all test queries for each commits, not only yours or related to this PR. That's why it fails. The true way to deal with it is to find the query on which ClickHouse crashes, validate it and submit an issue with tag |
nikitamikhaylov
approved these changes
Feb 8, 2021
This was referenced Feb 9, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Feb 9, 2021
…done in clickhouse-copier
robot-clickhouse
pushed a commit
that referenced
this pull request
Feb 9, 2021
… done in clickhouse-copier
robot-clickhouse
pushed a commit
that referenced
this pull request
Feb 9, 2021
… done in clickhouse-copier
robot-clickhouse
pushed a commit
that referenced
this pull request
Feb 9, 2021
…done in clickhouse-copier
nikitamikhaylov
added a commit
that referenced
this pull request
Feb 10, 2021
Backport #19743 to 21.2: Drop helping tables when the whole table is done in clickhouse-copier
nikitamikhaylov
added a commit
that referenced
this pull request
Feb 10, 2021
Backport #19743 to 20.12: Drop helping tables when the whole table is done in clickhouse-copier
nikitamikhaylov
added a commit
that referenced
this pull request
Feb 10, 2021
Backport #19743 to 21.1: Drop helping tables when the whole table is done in clickhouse-copier
nikitamikhaylov
added a commit
that referenced
this pull request
Feb 10, 2021
Backport #19743 to 20.11: Drop helping tables when the whole table is done in clickhouse-copier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix a bug that moving pieces to destination table may failed in case of launching multiple clickhouse-copiers.
Detailed description / Documentation draft:
When launching multiple clickhouse-copiers, the one moving pieces to destination table may spend long time. However, before it finished, the others had executed
tryProcessTable()beyondmax_table_triestimes, and then all the piece tables had been dropped. As a result, the pieces moving failed.@alexey-milovidov