Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aarch64: Re-enable S3 #22484

Merged

Conversation

mastertheknife
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Re-enable the S3 (AWS) library on aarch64
...

Detailed description / Documentation draft:
This one seemed strange to me, because this is not some low-level platform library. Its a library that pretty much does REST requests.
And many of the ARM instances are on AWS, making it likely that they'll need the S3 feature.
This feature gets successfully built for ppc64le, so why not aarch64 as well?
It was disabled in the commit below with reason "ARM minimal build", but i believe this shouldn't be a minimal build anymore :)
521e2e7
...

Copy link
Member

@alexey-milovidov alexey-milovidov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Maybe it was disabled just in case. Will see.

PS. I also expect that ARM version will be popular in AWS, although it is:

  • not tested in CI;
  • there are known issues.

@alexey-milovidov
Copy link
Member

Ok, it's cross-compiled successfully for AArch64.

@alexey-milovidov alexey-milovidov merged commit 3827789 into ClickHouse:master Apr 2, 2021
@robot-clickhouse robot-clickhouse added the pr-build Pull request with build/testing/packaging improvement label Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build Pull request with build/testing/packaging improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants