Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qualified names for right columns for storage join #23769

Merged
merged 7 commits into from
Jun 1, 2021

Conversation

vdimir
Copy link
Member

@vdimir vdimir commented Apr 29, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Handle column name clashes for storage join, close #20309

@robot-clickhouse robot-clickhouse added the pr-improvement Pull request with some product improvements label Apr 29, 2021
@vdimir vdimir marked this pull request as draft April 29, 2021 15:59
@vdimir vdimir marked this pull request as ready for review May 6, 2021 06:10
@vdimir
Copy link
Member Author

vdimir commented May 11, 2021

Seems not related

Functional stateless tests (debug) https://clickhouse-test-reports.s3.yandex.net/23769/cb89a2be9783de646c95ee8c424ce6a664c7dffc/functional_stateless_tests_(debug).html#fail1

2021-05-10 19:04:25 01526_initial_query_id:                                                 [ FAIL ] 26.40 sec. - having exception:
2021-05-10 19:04:25 Code: 216, e.displayText() = DB::Exception: Query with id = 87b95e8dff43c23850a5447074354e75 is already running. (version 21.6.1.6793)
2021-05-10 19:04:25 1	1
2021-05-10 19:04:25 
2021-05-10 19:04:25 Database: test_oqo49g

test_jbod_balancer/test.py::test_replicated_balanced_merge_fetch flaky last ten days

@akuzm akuzm merged commit f51ecf8 into ClickHouse:master Jun 1, 2021
@akuzm akuzm self-assigned this Jun 1, 2021
@vdimir vdimir deleted the issue-20309 branch June 1, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StorageJoin and with equals column names
3 participants