Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non joined stream structure #27217

Merged
merged 4 commits into from
Aug 9, 2021
Merged

Conversation

vdimir
Copy link
Member

@vdimir vdimir commented Aug 5, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix column structure in merge join, close #27091

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Aug 5, 2021
@vdimir vdimir changed the title Check if NotJoined::right_nullability_removes is used Fix non joined stream structure Aug 6, 2021
@vdimir vdimir mentioned this pull request Aug 6, 2021
Copy link
Member

@alexey-milovidov alexey-milovidov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok as long as it fixed the issue... Let's merge?

@alexey-milovidov alexey-milovidov self-assigned this Aug 8, 2021
@vdimir
Copy link
Member Author

vdimir commented Aug 9, 2021

I'm ok as long as it fixed the issue... Let's merge?

I also want to do some small refactoring around NonJoined (#27299). But yes, I suppose it's better to merge this now and I'll continue refactoring in separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default pr-no-backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

partial merge join: 'Bad cast from type DB::ColumnNullable to DB::ColumnString'
3 participants