-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add four letter commands to keeper #28981
Add four letter commands to keeper #28981
Conversation
...cker/control/jepsen/target/classes/META-INF/maven/jepsen.keeper/jepsen.keeper/pom.properties
Outdated
Show resolved
Hide resolved
@alesapin if the pr is ok, I will work on the rest part. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general LGTM. Let's implement several more interesting commands!
@JackyWoo How is it going?) |
@alesapin Sorry for late reply. Because We are in the biggest event of the year, the work delayed. I will add more commands in two or three weaks. |
f72f77d
to
fe28a52
Compare
73a1321
to
a60663e
Compare
Add 4lw command: mntr, srst, conf
Change log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Are you going to add more commands in this PR? Or we can merge it and continue in a new one?
@alesapin I intend to add most Zookeeper 4lw commands and |
Great idea. Let's continue in this PR, I'm not going to create huge changes in |
Ok, thank you. In So what's you opinion? |
I think it's Ok. SnapshotableHashTable has very limited use, so it shouldn't affect anything. |
Ok, I will work on it. |
@alesapin add |
…ckHouse into JackyWoo_add_4_letter_words_commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work, thanks.
…ckHouse into JackyWoo_add_4_letter_words_commands
…ckHouse into JackyWoo_add_4_letter_words_commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
…ckHouse into JackyWoo_add_4_letter_words_commands
…ckHouse into JackyWoo_add_4_letter_words_commands
@Mergifyio update |
☑️ Nothing to do
|
Finally fixed:
|
|
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
We need to implement similar commands in clickhouse-keeper: https://zookeeper.apache.org/doc/r3.4.8/zookeeperAdmin.html#sc_zkCommands
Detailed description / Documentation draft:
Because the first request of a connection is hand shake request whose first 4 characters is request length and the length is fixed 44 or 45. All 4lw code is larger than 2^24 or lower than 0, so collision never happens.
The pr is still WIP the first commit only add 'ruok' command.
The pr will close #28649 #26976.