Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start keeper asynchronously in some cases #30170

Merged
merged 8 commits into from
Oct 19, 2021
Merged

Start keeper asynchronously in some cases #30170

merged 8 commits into from
Oct 19, 2021

Conversation

alesapin
Copy link
Member

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Now Keeper (as part of clickhouse-server) will start asynchronously if it can connect to some other node.

@robot-clickhouse robot-clickhouse added the pr-improvement Pull request with some product improvements label Oct 14, 2021
@qoega
Copy link
Member

qoega commented Oct 14, 2021

And what is the use case?

@alesapin
Copy link
Member Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Oct 14, 2021

Command update: success

Branch has been successfully updated

@alesapin
Copy link
Member Author

?

When you start fresh empty replica it's better to connect to some other node and receive snapshot/logs from leader asynchronously.

@alesapin
Copy link
Member Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Oct 15, 2021

Command update: success

Branch has been successfully updated

@tavplubix tavplubix self-assigned this Oct 15, 2021
programs/keeper/Keeper.cpp Outdated Show resolved Hide resolved
src/Interpreters/Context.cpp Outdated Show resolved Hide resolved
src/Server/KeeperTCPHandler.cpp Show resolved Hide resolved
programs/server/Server.cpp Outdated Show resolved Hide resolved
@tavplubix
Copy link
Member

Integration tests (release) - test_keeper_two_nodes_cluster/test.py::test_read_write_two_nodes_with_blocade

@alesapin
Copy link
Member Author

Integration tests (release) - test_keeper_two_nodes_cluster/test.py::test_read_write_two_nodes_with_blocade

Actually looks flaky and unrelated to changes.

@alesapin
Copy link
Member Author

Checked logs from test_keeper_two_nodes_cluster/test.py::test_read_write_two_nodes_with_blocade. Looks like PartitionManager just didn't partition network for some reason: https://gist.github.com/alesapin/9105c15fcbdc79e50e0045487d7ac43e

Or it's a wrong log.

@alesapin alesapin merged commit 53ad965 into master Oct 19, 2021
@alesapin alesapin deleted the debug_keeper branch October 19, 2021 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants