optimize file segment PARTIALLY_DOWNLOADED get read buffer #37338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-improvement
kssenii
added
the
can be tested
kssenii
requested changes
May 19, 2022
|
|
||
| auto downloader_id = file_segment->getOrSetDownloader(); |
There was a problem hiding this comment.
This would not be fully correct.
It is possible that can_start_from_cache is false, then it can become true right before calling file_segment->getOrSetDownlaoder() which can also turn out as true. As a result we will use a buffer which reads from remote fs, but in fact should start with cached buffer. So we anyway need this can_start_from_cache check after if (downloader_id == file_segment->getCallerId()).
Let's leave this can_start_from_cache check in both places.
There was a problem hiding this comment.
I got it, I will change my code. please review later.
xiedeyantu
force-pushed
the
optimize-cache
branch
from
3a51f30 to
6338368
Compare
kssenii
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
optimize file segment PARTIALLY_DOWNLOADED get read buffer