Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BackgroundSchedulePool remove Poco::NotificationQueue #38028

Merged

Conversation

kitaisreal
Copy link
Contributor

@kitaisreal kitaisreal commented Jun 13, 2022

Changelog category (leave one):

  • Performance Improvement

BackgroundSchedulePool produce a lot of calls to wait with timeout for NotificationQueue. Such calls are also visible on flame graphs and for some benchmarks can take 15-20% of CPU time.

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix excessive CPU usage in background when there are a lot of tables.

@kitaisreal kitaisreal added the can be tested Allows running workflows for external contributors label Jun 13, 2022
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jun 13, 2022
@nikitamikhaylov nikitamikhaylov self-assigned this Jun 13, 2022
@kitaisreal
Copy link
Contributor Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2022

update

✅ Branch has been successfully updated

@kitaisreal kitaisreal force-pushed the background-schedule-pool-refactoring branch from d5db498 to bff82b9 Compare June 14, 2022 19:43
@kitaisreal
Copy link
Contributor Author

kitaisreal commented Jun 15, 2022

Query:

SELECT sum(WatchID) FROM hits_100m_obfuscated GROUP BY WatchID FORMAT Null;

Before:
background_pool_before
After:
background_pool_updated

Background pool is BgSchPool.

@kitaisreal
Copy link
Contributor Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jun 15, 2022

update

✅ Branch has been successfully updated

@robot-ch-test-poll1 robot-ch-test-poll1 added pr-performance Pull request with some performance improvements and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Jun 15, 2022
@kitaisreal kitaisreal merged commit 3eea38f into ClickHouse:master Jun 15, 2022
@den-crane den-crane mentioned this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-performance Pull request with some performance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants