-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generate_series function #59390
Add generate_series function #59390
Conversation
This is an automatic comment. The PR descriptions does not match the template. Please, edit it accordingly. The error is: Changelog category is empty |
This is an automated comment for commit cc7a418 with description of existing statuses. It's updated for the latest CI running ⏳ Click here to open a full report in a separate page
Successful checks
|
|
bfadd23
to
623b425
Compare
…k/generate_series_function
@divanik, it slowed down, according to the performance tests. |
…k/generate_series_function
…k/generate_series_function
…k/generate_series_function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only nitpicks, otherwise LGTM
return pipe; | ||
} | ||
const auto & limit_length = limit_length_and_offset.first; | ||
const auto & limit_offset = limit_length_and_offset.second; | ||
|
||
/// If intersected ranges is limited or we can pushdown limit. | ||
if (!intersected_ranges.rbegin()->right.isPositiveInfinity() || should_pushdown_limit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we don't need this condition anymore?
…k/generate_series_function
…k/generate_series_function
Changelog category:
New Feature
Changelog entry:
Add generate_series as a table function. This function generates table with an arithmetic progression with natural numbers.
Documentation entry for user-facing changes