Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generate_series function #59390

Merged
merged 36 commits into from
Mar 21, 2024

Conversation

divanik
Copy link
Member

@divanik divanik commented Jan 30, 2024

Changelog category:

New Feature

Changelog entry:

Add generate_series as a table function. This function generates table with an arithmetic progression with natural numbers.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@CLAassistant
Copy link

CLAassistant commented Jan 30, 2024

CLA assistant check
All committers have signed the CLA.

@divanik divanik marked this pull request as draft January 30, 2024 17:11
@divanik divanik changed the title Initial working commit Add generate_seires function Jan 30, 2024
Copy link

clickhouse-ci bot commented Jan 30, 2024

This is an automatic comment. The PR descriptions does not match the template.

Please, edit it accordingly.

The error is: Changelog category is empty

@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Jan 30, 2024
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-feature Pull request with new product feature label Jan 30, 2024
@robot-clickhouse-ci-1
Copy link
Contributor

robot-clickhouse-ci-1 commented Jan 30, 2024

This is an automated comment for commit cc7a418 with description of existing statuses. It's updated for the latest CI running

⏳ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@alesapin alesapin self-assigned this Jan 30, 2024
@qoega
Copy link
Member

qoega commented Jan 31, 2024

  • tests
  • documentation
  • cla

@divanik divanik marked this pull request as ready for review February 6, 2024 14:36
@divanik divanik marked this pull request as draft February 6, 2024 14:36
@divanik divanik changed the title Add generate_seires function Add generate_series function Feb 6, 2024
@divanik divanik force-pushed the divanik/generate_series_function branch from bfadd23 to 623b425 Compare February 6, 2024 21:34
@alexey-milovidov
Copy link
Member

@divanik, it slowed down, according to the performance tests.

CMakeLists.txt Outdated Show resolved Hide resolved
@divanik divanik marked this pull request as ready for review March 15, 2024 11:30
@divanik divanik marked this pull request as draft March 15, 2024 11:31
@divanik divanik marked this pull request as ready for review March 18, 2024 16:24
Copy link
Member

@alesapin alesapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only nitpicks, otherwise LGTM

src/Common/iota.h Outdated Show resolved Hide resolved
src/Processors/QueryPlan/ReadFromSystemNumbersStep.cpp Outdated Show resolved Hide resolved
src/Processors/QueryPlan/ReadFromSystemNumbersStep.cpp Outdated Show resolved Hide resolved
src/Processors/QueryPlan/ReadFromSystemNumbersStep.cpp Outdated Show resolved Hide resolved
src/Storages/System/StorageSystemNumbers.cpp Outdated Show resolved Hide resolved
src/Storages/System/StorageSystemNumbers.cpp Show resolved Hide resolved
return pipe;
}
const auto & limit_length = limit_length_and_offset.first;
const auto & limit_offset = limit_length_and_offset.second;

/// If intersected ranges is limited or we can pushdown limit.
if (!intersected_ranges.rbegin()->right.isPositiveInfinity() || should_pushdown_limit)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we don't need this condition anymore?

@divanik divanik requested a review from alesapin March 20, 2024 16:04
@divanik divanik merged commit 9dbe7be into ClickHouse:master Mar 21, 2024
109 of 162 checks passed
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-feature Pull request with new product feature pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants