-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix corner case when passing update_insert_deduplication_token_in_dependent_materialized_views
#59544
Fix corner case when passing update_insert_deduplication_token_in_dependent_materialized_views
#59544
Conversation
This is an automatic comment. The PR descriptions does not match the template. Please, edit it accordingly. The error is: Changelog entry required for category 'Bug Fix (user-visible misbehavior in an official stable release)' |
This is an automated comment for commit 87cc319 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
tests/queries/0_stateless/02972_insert_deduplication_token_hierarchical_inserts.sql
Outdated
Show resolved
Hide resolved
tests/queries/0_stateless/02972_insert_deduplication_token_hierarchical_inserts.sql
Outdated
Show resolved
Hide resolved
c44c10c
to
2fb7f98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job.
Integration test failures seem related to flaky tests:
|
…deduplication_token_in_dependent_materialized_views`
Backport #59544 to 24.1: Fix corner case when passing `update_insert_deduplication_token_in_dependent_materialized_views`
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix a corner case when passing
update_insert_deduplication_token_in_dependent_materialized_views
setting. There is one corner case not covered due to the absence of tables in the path:For this reason, I changed the update method for the insert deduplication token from the table ID to the view ID.