Rename dns_cache_max_size to dns_cache_max_entries

[allmazz]

See #60257 (comment)

Changelog category (leave one):

• Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Renamed server setting dns_cache_max_size to dns_cache_max_entries to reduce ambiguity

[pufit]

The CacheBase class here https://github.com/ClickHouse/ClickHouse/blob/master/src/Common/DNSResolver.cpp#L179 takes an optional template argument WeightFunction.

The default weight function is this
https://github.com/ClickHouse/ClickHouse/blob/master/src/Common/ICachePolicy.h#L15

So we need to change either the setting (e.g., dns_cache_max_entries) or add a correct weight function.

[rschu1ze]

The CacheBase class here https://github.com/ClickHouse/ClickHouse/blob/master/src/Common/DNSResolver.cpp#L179 takes an optional template argument WeightFunction.

The default weight function is this https://github.com/ClickHouse/ClickHouse/blob/master/src/Common/ICachePolicy.h#L15

So we need to change either the setting (e.g., dns_cache_max_entries) or add a correct weight function.

Just curious: why? The purpose of this PR is to increase the DNS cache size (see #60257 (comment)), and not change the relative weight of entries.

[pufit]

Just curious: why? The purpose of this PR is to increase the DNS cache size (see #60257 (comment)), and not change the relative weight of entries.

IMHO, dns_cache_max_size should limit the actual size of the cache in bytes. Otherwise, the setting's name is very counterintuitive.

[CLAassistant]

All committers have signed the CLA.

[robot-ch-test-poll1]

This is an automated comment for commit 39457cd with description of existing statuses. It's updated for the latest CI running

⏳ Click here to open a full report in a separate page

Successful checks

Check name	Description	Status
A Sync	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Mergeable Check	Checks if all other necessary checks are successful	✅ success
PR Check	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success

Check name	Description	Status
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	⏳ pending